We require contributors to sign our Contributor License Agreement, and we don't have @jasikpark on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@cla-bot check

The cla-bot has been summoned, and re-checked this pull request!

Hey @jasikpark 👋

I tested VS Code on both macOS and Windows, and in both cases cmd-d/ctrl-d has no effect. According to VS Code’s documentation, the shortcut to split the editor is cmd-\ on macOS and ctrl-\ on Windows, shortcuts Zed already includes in its default keymap.

I’m closing this pull request but, if there's something I'm missing, feel free to share more details. 🙂

I've got it on macOS VS Code, and it's not a user-defined keyboard shortcut.

Hey @jasikpark 👋

I tested VS Code on both macOS and Windows, and in both cases cmd-d/ctrl-d has no effect. According to VS Code’s documentation, the shortcut to split the editor is cmd-\ on macOS and ctrl-\ on Windows, shortcuts Zed already includes in its default keymap.

I’m closing this pull request but, if there's something I'm missing, feel free to share more details. 🙂

Not for the editor, but for the terminal. Though I'm not finding any docs that describe splitting the terminal in VS Code to provide alternative proof...

Not for the editor, but for the terminal. Though I'm not finding any docs that describe splitting the terminal in VS Code to provide alternative proof...

Got it! Sorry, I got confused and completely missed that this was terminal specific. I've been able to confirm that VS Code does indeed use cmd-\ to split the editor and cmd-d to split the terminal, on MacOS.

Since cmd-d in the Terminal context doesn't conflict with any existing binding let's go ahead and add this. Seeing as we're updating the MacOS ones, would you also be able to update the corresponding default bindings on Windows and Linux bindings to ctrl-shift-5? Thanks!

Done!

Thank you @jasikpark ! I ended up pushing a commit to your branch and updating the release notes, will merge this now 🙂

Thank you @jasikpark ! I ended up pushing a commit to your branch and updating the release notes, will merge this now 🙂

Ah, the macOS keyboard shortcut is listed as just cmd rather than cmd+D in the release notes 😅

Glad this got in though!

Ah, the macOS keyboard shortcut is listed as just cmd rather than cmd+D in the release notes 😅

I'll see if I can reach out to someone internally in order to get this fixed... 🫠
Thank you for pointing that out!

Hey @jasikpark, no worries on the release notes, just edit them here. The release notes script we run isn't tied to what gets merged in git, the script runs around and fetches all the PR bodies from GitHub. The script was written this way intentionally so we can update the PR bodies after the PR is merged and those changes will make it into the compiled notes we put together on release Zednesday. You can just edit it now.

cool, seems smart - I feel like I prefer the approach in https://github.com/changesets/changesets where the release notes are in a special file tracked for each PR <3

https://github.com/changesets/changesets/blob/main/docs/intro-to-using-changesets.md

(rust version: https://github.com/knope-dev/knope)